Enable regenerator for Hermes dev mode transform profile #52651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78450695 |
dannysu
force-pushed
the
export-D78450695
branch
from
3b6a57d to
b401f2b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78450695 |
dannysu
force-pushed
the
export-D78450695
branch
from
b401f2b to
6af0d04
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78450695 |
Summary: Changelog: [Internal] Reviewed By: robhogan Differential Revision: D78450695
dannysu
force-pushed
the
export-D78450695
branch
from
6af0d04 to
28031f6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78450695 |
Collaborator
|
This pull request was successfully merged by @dannysu in fb0e4ee When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in fb0e4ee. |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
) Summary: Pull Request resolved: facebook#52651 Changelog: [Internal] Last year the `hermes-canary` profile was used to enable certain apps to use Static Hermes by enabling regenerator because debugger support for generator wasn't finished yet. However, we actually could have just keyed off of `options.dev` and still kept using `hermes-stable`. The `hermes-canary` profile is actually meant to be used to run experiments. We should free up this profile to return it to the original intended purpose. This diff makes all hermes profiles' dev mode use regenerator. Existing SH apps using `hermes-canary` should be unaffected. And apps using Hermes will change to use regenerator in dev mode, but that should be ok. Reviewed By: robhogan Differential Revision: D78450695 fbshipit-source-id: eb6a87fbc1f0e08d490fd0d1baa3611248f95764
2 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Sep 26, 2025
# Why fix test errors: https://github.com/expo/expo/runs/51240288563 # How - [config-plugins] update template snapshot from template changes - [babel-preset] update test coming from @react-native/babel-preset bump. specifically facebook/react-native#52651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Differential Revision: D78450695